Messages in this thread | | | From | Frans Pop <> | Subject | Re: [PATCH] ia64: minor Makefile simplification through use of cc-ifversion | Date | Fri, 24 Jul 2009 20:23:11 +0200 |
| |
On Friday 24 July 2009, Peter Chubb wrote: > >>>>> "Sam" == Sam Ravnborg <sam@ravnborg.org> writes: > Sam> The above change is correct. But I really wonder if the original > Sam> code was correct? Do we really only want to use the -mtune > Sam> options for this specific gcc version? If this is indeed the > Sam> case this deserves a comment explaning this. > > I suspect it should be all compilers after this one. -mtune=mckinley > didn't work very well in the early gcc 3 compilers and didn't exist in > version 2.
How would you like to handle that? As it is essentially a separate issue, my suggestion would be: apply my patch as is and then (if needed) commit a separate patch to fix the incorrect comparisons on top.
Cheers, FJP
| |