Messages in this thread | | | Subject | Re: [PATCH 6/6] regulator: Provide mode to status conversion function | From | Liam Girdwood <> | Date | Wed, 22 Jul 2009 21:41:28 +0100 |
| |
On Tue, 2009-07-21 at 16:00 +0100, Mark Brown wrote: > This is useful for implementing get_status() in terms of get_mode(). > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > drivers/regulator/core.c | 24 ++++++++++++++++++++++++ > include/linux/regulator/driver.h | 2 ++ > 2 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > index cba10ec..13d0f92 100644 > --- a/drivers/regulator/core.c > +++ b/drivers/regulator/core.c > @@ -1993,6 +1993,30 @@ int regulator_notifier_call_chain(struct regulator_dev *rdev, > } > EXPORT_SYMBOL_GPL(regulator_notifier_call_chain); > > +/** > + * regulator_mode_to_status - convert a regulator mode into a status > + * > + * @mode: Mode to convert > + * > + * Convert a regulator mode into a status. > + */ > +int regulator_mode_to_status(unsigned int mode) > +{ > + switch (mode) { > + case REGULATOR_MODE_FAST: > + return REGULATOR_STATUS_FAST; > + case REGULATOR_MODE_NORMAL: > + return REGULATOR_STATUS_NORMAL; > + case REGULATOR_MODE_IDLE: > + return REGULATOR_STATUS_IDLE; > + case REGULATOR_STATUS_STANDBY: > + return REGULATOR_STATUS_STANDBY; > + default: > + return 0; > + } > +} > +EXPORT_SYMBOL_GPL(regulator_mode_to_status); > + > /* > * To avoid cluttering sysfs (and memory) with useless state, only > * create attributes that can be meaningfully displayed. > diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h > index 60efbd1..73c9cd6 100644 > --- a/include/linux/regulator/driver.h > +++ b/include/linux/regulator/driver.h > @@ -195,6 +195,8 @@ void *rdev_get_drvdata(struct regulator_dev *rdev); > struct device *rdev_get_dev(struct regulator_dev *rdev); > int rdev_get_id(struct regulator_dev *rdev); > > +int regulator_mode_to_status(unsigned int); > + > void *regulator_get_init_drvdata(struct regulator_init_data *reg_init_data); > > #endif
I've applied all patches, but I'm wondering whether it would be better to eventually merge MODE and STATUS. i.e. have REGULATOR_FAST instead of REGULATOR_STATUS_FAST and REGULATOR_MODE_FAST.
Thanks
Liam
| |