lkml.org 
[lkml]   [2009]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH] register at91_ether using platform_driver_probe
    Date
    On Tuesday 21 July 2009, Uwe Kleine-König wrote:
    > at91ether_probe lives in .init.text, so using platform_driver_register
    > to register it is wrong because binding a device after the init memory
    > is discarded (e.g. via sysfs) results in an oops.
    >
    > As requested by David Brownell platform_driver_probe is used instead of
    > moving the probe function to .devinit.text as proposed initially.
    > This saves some memory, but devices registered after the driver is
    > probed are not bound (probably there are none) and binding via sysfs
    > isn't possible.

    Right, these devices do not hotplug.

    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > Cc: David Brownell <dbrownell@users.sourceforge.net>

    Acked-by: David Brownell <dbrownell@users.sourceforge.net>

    .... and thanks for doing it this way. :)

    > Cc: netdev@vger.kernel.org
    > Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
    > Cc: Marc Pignat <marc.pignat@hevs.ch>
    > Cc: Andrew Victor <linux@maxim.org.za>
    > Cc: Roel Kluin <12o3l@tiscali.nl>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: Greg Kroah-Hartman <gregkh@suse.de>
    >
    > ---
    > drivers/net/arm/at91_ether.c | 3 +--
    > 1 files changed, 1 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c
    > index 2e7419a..5041d10 100644
    > --- a/drivers/net/arm/at91_ether.c
    > +++ b/drivers/net/arm/at91_ether.c
    > @@ -1228,7 +1228,6 @@ static int at91ether_resume(struct platform_device *pdev)
    > #endif
    >
    > static struct platform_driver at91ether_driver = {
    > - .probe = at91ether_probe,
    > .remove = __devexit_p(at91ether_remove),
    > .suspend = at91ether_suspend,
    > .resume = at91ether_resume,
    > @@ -1240,7 +1239,7 @@ static struct platform_driver at91ether_driver = {
    >
    > static int __init at91ether_init(void)
    > {
    > - return platform_driver_register(&at91ether_driver);
    > + return platform_driver_probe(&at91ether_driver, at91ether_probe);
    > }
    >
    > static void __exit at91ether_exit(void)
    > --
    > tg: (4b0a840..) t/platsection/at91ether_driver (depends on: linus/master)
    >
    >



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-22 19:39    [W:4.167 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site