Messages in this thread | | | Date | Wed, 22 Jul 2009 08:48:48 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Linux 2.6.27.27 |
| |
On Wed, 22 Jul 2009, Krzysztof Oledzki wrote:
> > > On Tue, 21 Jul 2009, Linus Torvalds wrote: > > > > IOW, like this.
Yeah, I'm a moron. Not at _all_ like that. I wish I hadn't sent out the patch, you'd have done it correctly by hand from my description.
> > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c > > index 5c1a2c0..af4a15c 100644 > > --- a/drivers/video/fbmon.c > > +++ b/drivers/video/fbmon.c > > @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix) > > > > static int edid_checksum(unsigned char *edid) > > { > > - unsigned char i, csum = 0, all_null = 0; > > - int err = 0, fix = check_edid(edid); > > + unsigned csum = 0, all_null = 0; > > + int i, err = 0, fix = check_edid(edid);
I don't know where the 'char' disappeared, but that was obviously not intended. I just meant to move the 'i' from one line to the other.
> > > > if (fix) > > fix_edid(edid, fix); > > Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl> > > On condition, that you keep "unsigned char" here. ;)
Indeed. I'll commit the fixed version. Thanks for testing and sorry for the idiot patch.
Linus
| |