Messages in this thread |  | | | Date | Wed, 22 Jul 2009 14:05:55 +0100 (BST) | | From | Hugh Dickins <> | | Subject | Re: [PATCH 00/10] ksm resend |
| |
On Tue, 21 Jul 2009, Andrea Arcangeli wrote: > On Fri, Jul 17, 2009 at 08:30:40PM +0300, Izik Eidus wrote: > > The code still need to get Andrea Arcangeli acks. > > (he was busy and will ack it later). > > Ack it all except that detail in 6/10
Thanks a lot, Andrea.
> as I'm unconvinced about ksm > pages having to return 1 on PageAnon check. I believe they deserve a > different bitflag in the mapping pointer. The smallest possible > alignment for mapping pointer is 4 on 32bit archs so there is space > for it
Yes, I believe they'll deserve that too, but set in addition to PAGE_MAPPING_ANON. And perhaps you or someone else will then have another use for the new bit when PAGE_MAPPING_ANON is not set.
> and later it can be renamed EXTERNAL to generalize. We shall > make good use of that bitflag as it's quite precious to introduce > non-linearity in linear vmas, and not wire it to KSM only.
You have something in mind here...
> But in > meantime we'll get better testing coverage by not having that PageKsm > == PageAnon invariant I think that I doubt we're going to retain (at > least with this implementation of PageKsm).
PageKsm subset of PageAnon: I expect to retain that.
Hugh
|  |