Messages in this thread | | | Date | Tue, 21 Jul 2009 20:18:55 -0700 (PDT) | Subject | Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq | From | David Miller <> |
| |
From: Peter Zijlstra <peterz@infradead.org> Date: Fri, 17 Jul 2009 14:14:52 +0200
> On Tue, 2009-07-14 at 09:42 -0700, Linus Torvalds wrote: >> >> On Tue, 14 Jul 2009, Peter Zijlstra wrote: >> > >> > Linus really hated the softirq mode, which is what prompted me to change >> > that. >> > >> > Now, it might be he only hated the particular interface and the >> > resulting code, but I think to remember he simply thought the whole >> > thing daft. >> >> Yes. And I hated the bugs it had. >> >> Don't make something as core as timers any more complicated. Don't take >> locks in timers and then complain about deadlocks. If your locking is >> broken, don't make the core timers be idiotically broken. >> >> Because it was. The code was a total mess to follow, and had bugs. > > How would something like the below work for people?
I like it, but like Linus said it probably belongs in kernel/softirq.c
| |