Messages in this thread | | | Date | Tue, 21 Jul 2009 09:06:20 -0700 | Subject | Re: [PATCH] copy over oom_adj value at fork time | From | Paul Menage <> |
| |
On Tue, Jul 21, 2009 at 12:19 AM, KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote: > > Paul, I'd like to clarily this duscussion. Doesn't Rik's patch fix your vfork issue or > you worry about generic ABI breaking issue? >
No, Rik's patch just fixes the lack of inheritability that David introduced originally. It doesn't address the problem that the intention of the patches is to disallow separate processes sharing the same VM from having different oom_adj scores, which breaks the previous ability to vfork() or clone(CLONE_VM) a child and set its oom_adj to a non-disabled value prior to execve().
I think that in the case of our job scheduler, we can probably change it to do a full fork() rather than clone(), at a little extra cost (copying the entire mm rather than just cloning a thread). Our job scheduler is generally a small process, so this shouldn't be too expensive. But for large processes, the overhead of a full mm copy is bigger.
Paul
| |