Messages in this thread | | | From | David Howells <> | Subject | Re: [RFC/PATCH] mm: Pass virtual address to [__]p{te,ud,md}_free_tlb() | Date | Mon, 20 Jul 2009 13:46:03 +0100 |
| |
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> Upcoming paches to support the new 64-bit "BookE" powerpc architecture > will need to have the virtual address corresponding to PTE page when > freeing it, due to the way the HW table walker works. > > Basically, the TLB can be loaded with "large" pages that cover the whole > virtual space (well, sort-of, half of it actually) represented by a PTE > page, and which contain an "indirect" bit indicating that this TLB entry > RPN points to an array of PTEs from which the TLB can then create direct > entries. Thus, in order to invalidate those when PTE pages are deleted, > we need the virtual address to pass to tlbilx or tlbivax instructions. > > The old trick of sticking it somewhere in the PTE page struct page sucks > too much, the address is almost readily available in all call sites and > almost everybody implemets these as macros, so we may as well add the > argument everywhere. I added it to the pmd and pud variants for consistency. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: David Howells <dhowells@redhat.com> [MN10300 & FRV]
| |