lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] sysrq, kdump: fix regression, revert "simplify sysrq-c handler"
    Lai Jiangshan <laijs@cn.fujitsu.com> writes:

    > 1) This fix breaks our tools.
    > This fix changes the ABI. panic_on_oops is default 0,
    > and a lots system do not specify the boot option "panic",
    > thus, Sysrq-c will not cause CrashDump(Kdump) as expected.

    How does it break your tools?

    > 2) When CONFIG_KEXEC=n, Sysrq-c should become an invalid
    > command like Sysrq-D(CONFIG_LOCKDEP, show-all-locks).
    > But this fix makes it a valid command and let it do a
    > hazard thing: cause a page fault(NULL dereference) in kernel.
    >
    > So, we revert this fix.

    The idea was to extend sysrq-d to also be a way of testing NULL
    pointer dereferences. How is that a bad idea?

    Eric


    \
     
     \ /
      Last update: 2009-07-20 21:25    [W:2.343 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site