lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] add SBC-FITPC2 watchdog driver
    From
    Date
    On Mon, 2009-07-20 at 18:53 +0300, Mike Rapoport wrote:
    > diff -Nru linux-2.6.31-rc3.orig/drivers/watchdog/sbc_fitpc2_wdt.c linux-2.6.31-rc3/drivers/watchdog/sbc_fitpc2_wdt.c
    > --- linux-2.6.31-rc3.orig/drivers/watchdog/sbc_fitpc2_wdt.c 1970-01-01 02:00:00.000000000 +0200
    > +++ linux-2.6.31-rc3/drivers/watchdog/sbc_fitpc2_wdt.c 2009-07-20 16:08:40.000000000 +0300

    Hi. Some trivial comments below:

    []

    > +static ssize_t
    > +fitpc2_wdt_write(struct file *file, const char *data, size_t len, loff_t *ppos)
    > +{
    > + if (len) {
    > + if (!nowayout) {
    > + size_t i;

    using
    if (!len)
    return 0;
    if (nowayout) {
    wdt_enable();
    return 0;
    }

    would reduce the indent a couple of levels.

    []

    > +static int fitpc2_wdt_release(struct inode *inode, struct file *file)
    > +{
    > + if (test_bit(WDT_OK_TO_CLOSE, &wdt_status)) {
    > + wdt_disable();
    > + printk(KERN_CRIT "WATCHDOG: Device disabled\n");

    I think you should verify the printk KERN_CRIT uses.
    This seems like this one should be KERN_INFO.

    []

    > +static int __init fitpc2_wdt_init(void)
    []
    > + printk(KERN_CRIT "WATCHDOG: board name is: %s. Should be SBC-FITPC2\n",
    > + dmi_get_system_info(DMI_BOARD_NAME));
    []
    > + printk(KERN_CRIT "WATCHDOG: I/O address 0x%04x already in use\n",
    > + COMMAND_PORT);
    []
    > + printk(KERN_CRIT "WATCHDOG: I/O address 0x%04x already in use\n",
    > + DATA_PORT);
    []
    > + printk(KERN_CRIT "WATCHDOG: margin must be in range 31 - 255"
    > + " seconds, you tried to set %d\n", margin);

    Maybe all of these should be KERN_ERR.

    You could use:

    #define pr_fmt(fmt) KBUILD_MODNAME " WATCHDOG: " fmt

    and convert the printk(KERN_<level> "WATCHDOG: " etc...)
    to pr_<level>(etc...)




    \
     
     \ /
      Last update: 2009-07-20 18:45    [W:0.021 / U:90.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site