Messages in this thread | | | Date | Thu, 2 Jul 2009 15:35:45 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] memcg: fix cgroup rmdir hang v4 |
| |
On Thu, 2 Jul 2009 12:00:05 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-07-01 10:47:47]:
> > -static void cgroup_wakeup_rmdir_waiters(const struct cgroup *cgrp) > > +static void cgroup_wakeup_rmdir_waiter(struct cgroup *cgrp) > > Should the function explictly mention rmdir? For now, yes. this is only for rmdir.
> Also something like > release_rmdir should be called release_and_wakeup to make the action > clearer. > Hm, I don't think this name is too bad. Comment is enough and if we have to change the behavior of cgroup-internal work, we have to rename this again. This name is not too much explaining but showing enough information.
> Looks good to me otherwise and clean. > Thank you.
Regards, -Kame
| |