Messages in this thread | | | Date | Thu, 2 Jul 2009 23:45:03 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] [MIPS] Hibernation: only save pages in system ram |
| |
> arch/mips/include/asm/page.h: > > ... > #ifdef CONFIG_FLATMEM > > #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < max_mapnr) > > #elif defined(CONFIG_SPARSEMEM) > > /* pfn_valid is defined in linux/mmzone.h */ > ... > > we can rewrite pfn_valid(pfn) to fix this problem, but I really do not > want to touch such a widely-used macro, so, I used another solution:
Well, fixing pfn_valid() is the right way to go. It makes mips behave like other architectures. Please do that.
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
NAK.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |