Messages in this thread | | | Date | Thu, 2 Jul 2009 22:27:04 +0100 | From | Alan Cox <> | Subject | Re: V3 minixfs bug |
| |
On Thu, 02 Jul 2009 17:13:42 -0400 "Doug Graham" <dgraham@nortel.com> wrote:
> Is anybody interested in bugs in the minixfs V3 support that probably > only turn up on big-endian machines, or on filesystems with more than > 64K inodes?
If you've found them then yes.
> The problem is that that there are a few places (three that I've found) > where the "inode" field of a minix_dir_entry is used without checking > first to see if the dirent is really a minix3_dir_entry. The inode number > in a V1/V2 dirent is 16 bits, whereas that in a V3 dirent is 32 bits. > Accessing > it as a 16 bit field when it really should be accessed as a 32 bit field > probably kinda sorta works on a little-endian machine, but leads to some > rather odd behaviour on big-endian machines. > > Here's a patch:
The one thing this needs for application is a Signed-off-by: line (see Documentation/SubmittingPatches).
Alan
| |