lkml.org 
[lkml]   [2009]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: Remove useless variable disable_x2apic
[Jaswinder Singh Rajput - Thu, Jul 02, 2009 at 10:33:59PM +0530]
|
| setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
|
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
| ---
| arch/x86/kernel/apic/apic.c | 2 --
| 1 files changed, 0 insertions(+), 2 deletions(-)
|
| diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
| index 8c7c042..0a1c283 100644
| --- a/arch/x86/kernel/apic/apic.c
| +++ b/arch/x86/kernel/apic/apic.c
| @@ -140,7 +140,6 @@ int x2apic_mode;
| #ifdef CONFIG_X86_X2APIC
| /* x2apic enabled before OS handover */
| static int x2apic_preenabled;
| -static int disable_x2apic;
| static __init int setup_nox2apic(char *str)
| {
| if (x2apic_enabled()) {
| @@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
| return 0;
| }
|
| - disable_x2apic = 1;
| setup_clear_cpu_cap(X86_FEATURE_X2APIC);
| return 0;
| }
| --
| 1.6.2.5
|

yes, at moment we use cpu_has_x2apic mostly.
Ack. But lets CC Suresh to be sure. Maybe
there is something in plans.

-- Cyrill


\
 
 \ /
  Last update: 2009-07-02 19:17    [W:0.053 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site