lkml.org 
[lkml]   [2009]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: fio mmap sequential read 30% regression


On Thu, 2 Jul 2009, Zhang, Yanmin wrote:
>
> Bisect down to below patch.
>
> ef00e08e26dd5d84271ef706262506b82195e752 ("readahead: clean up and
> simplify the code for filemap page fault readahead")
>
> The bisect is stable.

Hmm. That patch is the one patch in the whole series that should _not_
have changed any behavior, but it got forward-ported by something like 8
months, so maybe something changed in the meantime.

Also, I do think it changes the exact details of "ra->mmap_miss" (along
with the fault counters). The old code was really quite odd in the
statistics department, and would do some odd things wrt the miss counts
and statistics - because it had this re-try loop that essentially updated
the stats twice (once on the first try, and then once more when doing the
"retry_find" thing).

The patch gets rid of the hard-to-follow retry logic (it had that
"did_readaround" logic to determine if it was on the first loop or the
second one, and used those _sometimes_), and should _fix_ those stats, but
obviously all historical tuning had happened with the old stats. So it's
entirely possible that as part of "fixing" them, I actually broke what the
old logic tried to do.

There's also one _intentional_ change: the new code doesn't take the lock
on the page before it starts async read-ahead. That can certainly change
timings a lot. It _should_ cause better behavior (more IO overlap), but
depending on read-ahead code and the exact behavior of your IO subsystem,
maybe it causes you problems.

But it is also possible that the patch simply changes behavior in
unintended ways. Either originally, or due to being forward-ported with
all the other read-ahead changes. I'm not seeing it, though - the patch
still looks like it shouldn't change any semantics.

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.040 / U:1.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site