Messages in this thread | | | Date | Thu, 2 Jul 2009 12:41:11 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: sysctl to allow panic on IOCK NMI error |
| |
On Thu, Jul 02, 2009 at 09:53:05AM +0200, Ingo Molnar wrote: > > That shouldn't be a problem if we were about to panic(). For a > > more sophisticated attempt of recovery -- yes, that would have to > > be addressed. > > We are only panic-ing if the sysctl is set. The diagnostics would be > useful anyway. The proper approach would be to defer it a bit in the > non-panic case an read it out from some friendlier context - such as > the EDAC core.
Quickly skimming through code shows some functionality is there: drivers/edac/edac_pci{,_sysfs}.c but doesn't seem to be NMI safe. CCing some more people.
-- Regards/Gruss, Boris.
Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |