lkml.org 
[lkml]   [2009]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] tracing: use defined fields to print formats

* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> It seems that ftrace_format_##call() and
> ftrace_define_fields_##call() are duplicate more or less.
>
> trace_define_field() defines fields and links them into strcut
> ftrace_event_call. We reuse them to print formats and remove
> ftrace_format_##call(). It make all things simpler.
>
> TRACE_EVENT_FORMAT_NOFILTER is dropped. Because we should
> "trace_define_field()" fields for all struct ftrace_event_call,
> even it's no filter.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index 5c093ff..738b33d 100644

Minor request for future patches: could you please include the
diffstat all the time? Makes it much easier to see the general
impact of a patch.
Ingo


\
 
 \ /
  Last update: 2009-07-18 13:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site