Messages in this thread | | | Date | Fri, 17 Jul 2009 12:52:33 -0700 (PDT) | From | Sage Weil <> | Subject | Re: [PATCH 18/20] ceph: debugging |
| |
On Fri, 17 Jul 2009, Andi Kleen wrote: > Good. > > Sorry for not doing more (and more serious) reviews, not enough > time right now.
You've been helpful nonetheless, thanks! :)
> > #define _dout(fmt, args...) \ > > pr_debug(" %12.12s:%-4d : " fmt "%s", \ > > ceph_file_part(__FILE__, sizeof(__FILE__)), \ > > __LINE__, args); > > That seems like a wasteful way to do this -- i bet you could > shrink binary size with debugging on considerably if you move > the file_part into a function.
If you mean ceph_file_part shouldn't be inline, definitely. Beyond that I'm not sure what more to change... it's just a few extra chars on the format string and 2 calls instead of 1?
sage
| |