Messages in this thread | | | Date | Fri, 17 Jul 2009 20:56:41 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 18/20] ceph: debugging |
| |
Good.
Sorry for not doing more (and more serious) reviews, not enough time right now.
> #define _dout(fmt, args...) \ > pr_debug(" %12.12s:%-4d : " fmt "%s", \ > ceph_file_part(__FILE__, sizeof(__FILE__)), \ > __LINE__, args);
That seems like a wasteful way to do this -- i bet you could shrink binary size with debugging on considerably if you move the file_part into a function.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |