[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH -mm] throttle direct reclaim when too many pages are isolated already (v3)
    Andrew Morton wrote:

    > While I agree that handling fatal signals on the direct reclaim path
    > is probably a good thing, this seems like a fairly random place at
    > which to start the enhancement.

    You are right, the direct reclaim path has one other
    place where congestion_wait is called in a loop,
    do_try_to_free_pages itself - we'll probably want to
    break out of that loop too, if the task is about to
    die and free all its memory.

    > If we were to step back and approach this in a broader fashion, perhaps
    > we would find some commonality with the existing TIF_MEMDIE handling,
    > dunno.

    Good point - what is it that makes TIF_MEMDIE special
    wrt. other fatal signals, anyway?

    I wonder if we should not simply "help along" any task
    with fatal signals pending, anywhere in the VM (and maybe
    other places in the kernel, too).

    The faster we get rid of a killed process, the sooner its
    resources become available to the other processes.

    > And I question the testedness of v3 :)

    No question about that :)

    All rights reversed.

     \ /
      Last update: 2009-07-16 06:11    [W:0.021 / U:13.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site