lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip -v12 01/11] x86: instruction decoder API
Sam Ravnborg wrote:
>> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
>> new file mode 100644
>> index 0000000..01e079a
>> --- /dev/null
>> +++ b/arch/x86/include/asm/inat.h
>> @@ -0,0 +1,125 @@
>> +#ifndef _ASM_INAT_INAT_H
>> +#define _ASM_INAT_INAT_H
>
> [With reference to comment on patch 2/12...]
> You create inat.h here.
> Could you investigave what is needed to factor out the stuff
> needed from userspace so we can avoid the ugly havk where
> you redefine types.h?

Sorry, I'm a bit confusing.
Would you mean that I should break down user_include.h and
add those redefined types in inat.h?

> Maybe create a inat_types.h + inat.h as we do in other cases?

And inat_types.h has two parts, one for kernel, and one for
userspace(which is moved from user_include.h), is that right?

Thank you,

>
> Same for the other files that requred the types.h hack.
>
> Sam
>

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2009-07-16 19:31    [from the cache]
©2003-2011 Jasper Spaans