lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [KVM PATCH] KVM: introduce "xinterface" API for external interaction with guests
    > diff --git a/arch/x86/Kbuild b/arch/x86/Kbuild
    > index ad8ec35..9f50cc3 100644
    > --- a/arch/x86/Kbuild
    > +++ b/arch/x86/Kbuild
    > @@ -1,5 +1,7 @@
    >
    > -obj-$(CONFIG_KVM) += kvm/
    > +ifdef CONFIG_KVM
    > +obj-y += kvm/
    > +endif

    What was wrong with the old version?
    If this is because xinterface.o is builtin to the kernel then we should
    always visit kvm/ and use:

    obj-y += kvm/

    unconditionally.



    >
    > # Xen paravirtualization support
    > obj-$(CONFIG_XEN) += xen/
    > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
    > index afaaa76..80d951d 100644
    > --- a/arch/x86/kvm/Makefile
    > +++ b/arch/x86/kvm/Makefile
    > @@ -17,3 +17,7 @@ kvm-amd-y += svm.o
    > obj-$(CONFIG_KVM) += kvm.o
    > obj-$(CONFIG_KVM_INTEL) += kvm-intel.o
    > obj-$(CONFIG_KVM_AMD) += kvm-amd.o
    > +
    > +ifdef CONFIG_KVM
    > +obj-y += $(addprefix ../../../virt/kvm/, xinterface.o)
    > +endif
    And when we always visit kvm/ the above code snippet makes sense.
    Before we never visited kvm/ unless CONFIG_KVM was defined.

    Sam


    \
     
     \ /
      Last update: 2009-07-16 17:33    [W:0.021 / U:122.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site