lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/5] perf_counter: Make call graph option consistent
    On Thu, Jul 16, 2009 at 08:42:52PM +1000, Anton Blanchard wrote:
    > perf record uses -g for logging call graph data but perf report uses -c
    > to print call graph data. Be consistent and use -g everywhere for call graph
    > data.
    >
    > Also update the help text to reflect the current default - fractal,0.5
    >
    > Signed-off-by: Anton Blanchard <anton@samba.org>


    Thanks!

    Acked-by: Frederic Weisbecker <fweisbec@gmail.com>


    > ---
    >
    > Im not sure if it's too late to make this change, but I've tripped
    > up a number of times when I cycle between perf record and perf report.
    >
    > Index: linux.trees.git/tools/perf/builtin-report.c
    > ===================================================================
    > --- linux.trees.git.orig/tools/perf/builtin-report.c 2009-07-16 19:41:41.000000000 +1000
    > +++ linux.trees.git/tools/perf/builtin-report.c 2009-07-16 19:41:49.000000000 +1000
    > @@ -2005,9 +2005,9 @@
    > "regex filter to identify parent, see: '--sort parent'"),
    > OPT_BOOLEAN('x', "exclude-other", &exclude_other,
    > "Only display entries with parent-match"),
    > - OPT_CALLBACK_DEFAULT('c', "callchain", NULL, "output_type,min_percent",
    > + OPT_CALLBACK_DEFAULT('g', "call-graph", NULL, "output_type,min_percent",
    > "Display callchains using output_type and min percent threshold. "
    > - "Default: flat,0", &parse_callchain_opt, callchain_default_opt),
    > + "Default: fractal,0.5", &parse_callchain_opt, callchain_default_opt),
    > OPT_STRING('d', "dsos", &dso_list_str, "dso[,dso...]",
    > "only consider symbols in these dsos"),
    > OPT_STRING('C', "comms", &comm_list_str, "comm[,comm...]",
    >
    > --
    >



    \
     
     \ /
      Last update: 2009-07-16 16:53    [W:3.206 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site