Messages in this thread | | | Subject | Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c | From | Subrata Modak <> | Date | Thu, 16 Jul 2009 18:40:18 +0530 |
| |
On Thu, 2009-07-16 at 15:54 +0300, Artem Bityutskiy wrote: > On Thu, 2009-07-16 at 18:11 +0530, Subrata Modak wrote: > > does not use: > > "const struct ubifs_info *c" > > inside the inline function. I do not see any practical usage of > > "const struct ubifs_info *c" in the functions key_read() and key_write(). > > Is there something which i am missing to understand ? > > > > When i applied the following patch, still the "fs/ubifs/" code compiled fine. > > If the below fix is correct, i can try fixing some other functions i saw > > having similar defects. > > Yeah, I think the reason why we have this extra argument there is that > we assumed there will be several key schemes. It is possible to add more > than one, but we use only one. > > Since you have already spent your time for this, could you please check > if removing this 'c' makes the code smaller? If not, I'd prefer not to
Ok. I would let you know soon.
Regards-- Subrata
> remove it. >
| |