Messages in this thread | | | Subject | Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c | From | Subrata Modak <> | Date | Thu, 16 Jul 2009 16:51:49 +0530 |
| |
On Thu, 2009-07-16 at 14:12 +0300, Artem Bityutskiy wrote: > On Thu, 2009-07-16 at 16:34 +0530, Subrata Modak wrote: > > Correct. There has been other warning fixes i have sent to LKML, where i > > have tweaked the code to fix the compilation, but, code tweaking may not > > be possible in this case. However , i would still investigate. > > I do not think that in _general_ it is a good idea to tweak code just > to have gcc pleased, granted the code is correct. In this case it is > more preferable to shut it up, e.g., using 'unitialized_var()'.
Great. I would write more description in the patch then. Thanks.
Regards-- Subrata
>
| |