[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
    On Wed, 2009-07-15 at 20:16 +0200, Stefan Richter wrote:
    > Artem Bityutskiy wrote:
    > > On Wed, 2009-07-15 at 07:49 +0530, Subrata Modak wrote:
    > >> Following fix is inspired by David Howells fix few days back:
    > >>,
    > >>
    > >> Signed-off-by: Subrata Modak<>,
    > >> ---
    > >
    > > Removed junk comma at the end of "signed-off-by" and pushed to
    > > the ubifs-2.6.git tree:
    > >
    > >;h=5c1507e6097c4abc13bbad69de137366c9043f22
    > >
    > > Thanks.
    > >
    > The changelog of the patch is bad. "Fix compilation warning" is not
    > correct. It should be "suppress compilation warning" or "annotate
    > unitialized variable" or whatever --- i.e. it should say what it does.

    For me this sounds the same. But probably your version is better
    English. I'll change this.

    > Furthermore, since the 3 lines context around the change in the diff do
    > not reveal why the chosen "fix" is correct and desirable, the changelog
    > should also leave a note why it's done this way.

    The changelog says which kind of warning is fixed, I though it is
    obvious what is the warning. At lease for me it would.

    But if Subrata sends me the warning he sees, I'll change that.
    Thankfully I did not push the patch to ubifs-2.6.git/linux-next
    which I never re-base, but pushed it to master which I do rebase
    and it is documented here:

    So I may just amend the commit's message.

    > The patch form David Howells which is quoted here has an equally bad
    > subject, but at least its changelog goes on to explain what the patch
    > really does and why it does it in the proposed way.

    Well, I just thought this type of warnings and way of fixing is very
    standard because I saw many similar fixes all over the place.

    Anyway, amended the patch like this so far:;h=5c1507e6097c4abc13bbad69de137366c9043f22

    Best regards,
    Artem Bityutskiy (Битюцкий Артём)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-07-16 12:01    [W:0.024 / U:0.116 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site