lkml.org 
[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix
    KOSAKI Motohiro wrote:
    > Subject: [PATCH] mm: shrink_inactive_lis() nr_scan accounting fix fix
    >
    > If sc->isolate_pages() return 0, we don't need to call shrink_page_list().
    > In past days, shrink_inactive_list() handled it properly.
    >
    > But commit fb8d14e1 (three years ago commit!) breaked it. current shrink_inactive_list()
    > always call shrink_page_list() although isolate_pages() return 0.
    >
    > This patch restore proper return value check.
    >
    >
    > Requirements:
    > o "nr_taken == 0" condition should stay before calling shrink_page_list().
    > o "nr_taken == 0" condition should stay after nr_scan related statistics
    > modification.
    >
    >
    > Cc: Wu Fengguang <fengguang.wu@intel.com>
    > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

    Reviewed-by: Rik van Riel <riel@redhat.com>

    --
    All rights reversed.


    \
     
     \ /
      Last update: 2009-07-16 04:13    [W:0.023 / U:95.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site