Messages in this thread Patch in this message | | | Date | Wed, 15 Jul 2009 13:59:50 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] page-allocator: Ensure that processes that have been OOM killed exit the page allocator (resend) |
| |
On Wed, 15 Jul 2009, David Rientjes wrote:
> This only works for GFP_ATOMIC since the next iteration of the page > allocator will (probably) fail reclaim and simply invoke the oom killer > again, which will notice current has TIF_MEMDIE set and choose to do > nothing, at which time the allocator simply loops again. >
In other words, I'd propose this as an alternative patch.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1789,6 +1789,10 @@ rebalance: if (p->flags & PF_MEMALLOC) goto nopage; + /* Avoid allocations with no watermarks from looping endlessly */ + if (test_thread_flag(TIF_MEMDIE) && !(gfp_mask & __GFP_NOFAIL)) + goto nopage; + /* Try direct reclaim and then allocating */ page = __alloc_pages_direct_reclaim(gfp_mask, order, zonelist, high_zoneidx,
| |