lkml.org 
[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] SCSI: lpfc, don't dereference NULL
Thanks Jiri.

-- james s


Acked-By: James Smart <james.smart@emulex.com>


Jiri Slaby wrote:
> When kzalloc fails in lpfc_hba_alloc, don't dereference the NULL by
> lpfc_printf_log. Use dev_err instead.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index fc67cc6..2452dc9 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4130,8 +4130,7 @@ lpfc_hba_alloc(struct pci_dev *pdev)
> /* Allocate memory for HBA structure */
> phba = kzalloc(sizeof(struct lpfc_hba), GFP_KERNEL);
> if (!phba) {
> - lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
> - "1417 Failed to allocate hba struct.\n");
> + dev_err(&pdev->dev, "failed to allocate hba struct\n");
> return NULL;
> }
>


\
 
 \ /
  Last update: 2009-07-15 21:03    [W:0.032 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site