[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] ARM: copy_page.S: take into account the size of the cache line
    On Saturday 11 July 2009 02:51:23 ext Jamie Lokier wrote:
    > Kirill A. Shutemov wrote:
    > > From: Kirill A. Shutemov <>
    > >
    > > Optimized version of copy_page() was written with assumption that cache
    > > line size is 32 bytes. On Cortex-A8 cache line size is 64 bytes.
    > >
    > > This patch tries to generalize copy_page() to work with any cache line
    > > size if cache line size is multiple of 16 and page size is multiple of
    > > two cache line size.
    > >
    > > Unfortunately, kernel doesn't provide a macros with correct cache size.
    > > L1_CACHE_SHIFT is 5 on any ARM. So we have to define macros for this
    > > propose by ourself.
    > Why don't you fix L1_CACHE_SHIFT for Cortex-A8?

    That's the plan.

    Right now Kirill is on a vacation, but I think he can continue investigating
    this stuff when he is back and will come up with a clean solution.

    Fixing L1_CACHE_SHIFT may open a whole can of worms (fixing some old
    bugs, or breaking some things that might work only when incorrectly
    assuming that cache line is always 32 bytes). For example, looks like this
    thing in 'arch/arm/include/asm/dma-mapping.h' may be dangerous for
    ARM cores, which have cache line size different from 32:

    static inline int dma_get_cache_alignment(void)
    return 32;

    Best regards,
    Siarhei Siamashka

     \ /
      Last update: 2009-07-15 15:19    [W:0.031 / U:11.436 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site