lkml.org 
[lkml]   [2009]   [Jul]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 15 Jul 2009 12:17:13 +0900
FromTejun Heo <>
SubjectRe: [PATCH 04/10] percpu: make 4k first chunk allocator map memory
Hello,

David Howells wrote:
> Tejun Heo <tj@kernel.org> wrote:
>
>> + pr_info("PERCPU: %d 4k pages per cpu, static data %zu bytes\n",
>> + pcpu4k_unit_pages, static_size);
>
> It occurs to me that this is may include a bad assumption. Page size need not
> be 4K. I don't know that it matters, but looking at this:
>
>> + vm.size = num_possible_cpus() * pcpu4k_unit_pages << PAGE_SHIFT;
>> + vm_area_register_early(&vm, PAGE_SIZE);
>
> It might.

Yeah, I realized that after trying to convert powerpc64 and ia64 and
renamed it to page. I'll soon post the patches.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-07-15 05:21    [from the cache]
©2003-2009