[lkml]   [2009]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] move omap_udc's probe function to .devinit.text
    Hello David,

    On Sun, Jul 12, 2009 at 03:21:30PM -0700, David Brownell wrote:
    > On Sunday 12 July 2009, Russell King wrote:
    > >  David's approach is an enhancement whereas your patches
    > > are a bug fix.
    > Not an enhancement. Uwe's current approach causes regressions
    > in terms of kernel runtime footprint. That is, pages will newly
    > be made to sit around doing *nothing* forever, when they could
    > have been used to get Real Work done. And, pre-patches, they
    > would have been getting Real Work done.
    > If it weren't a regression I wouldn't have objected.
    IMHO my patches primarily fix possible oopses. I see your point that
    platform_driver_probe has some advantages, but I consider it too
    time-consuming to check for each of the initially 60+ patches when the
    respecting devices are registered.

    My intention is to point out a problem plus provide a safe fix.

    > All that adds up. There's no point to commiting patches that
    > do things wrong *and* waste space, then need to fix things up
    > again later when it's easy to do it right in the first place.

    Obviously it's arguable if it's wrong or not. I consider it at least
    better than doing nothing.

    Best regards

    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | |
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-07-13 11:13    [W:0.021 / U:130.488 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site