Messages in this thread | | | Subject | Re: HTC: touchscreen driver | From | Daniel Walker <> | Date | Mon, 13 Jul 2009 18:48:07 -0700 |
| |
On Tue, 2009-07-14 at 00:07 +0200, Pavel Machek wrote: > On Mon 2009-07-13 22:57:49, Pavel Machek wrote: > > Hi! > > > > I'm looking at synaptic touchscreen driver... who should be listed as > > an author? > > > > Changes I have so far are... > > > > checkpatch only has minor complains -- lines over 80 characters -- but > > the code is _way_ too deeply nested with way too little functions. > > Here's better cleanup. But... some functions are still _way_ too big. >
I'd put the nesting removal into another patch .. It makes reviewing more clear, your first patch was already fairly busy .. It would also make a bisect more fine grained if it lands on one of your patches.
Daniel
| |