Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH] wireless: wl12xx, fix lock imbalance | Date | Mon, 13 Jul 2009 23:24:26 +0200 |
| |
Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when wl12xx_chip_wakeup fails).
Not sure if the device should be powered off?
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> --- drivers/net/wireless/wl12xx/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c index 603d611..d241e4a 100644 --- a/drivers/net/wireless/wl12xx/main.c +++ b/drivers/net/wireless/wl12xx/main.c @@ -336,7 +336,7 @@ static int wl12xx_op_start(struct ieee80211_hw *hw) ret = wl12xx_chip_wakeup(wl); if (ret < 0) - return ret; + goto unlock; ret = wl->chip.op_boot(wl); if (ret < 0) @@ -357,7 +357,7 @@ static int wl12xx_op_start(struct ieee80211_hw *hw) out: if (ret < 0) wl12xx_power_off(wl); - +unlock: mutex_unlock(&wl->mutex); return ret; -- 1.6.3.2
| |