lkml.org 
[lkml]   [2009]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
FromDavid Brownell <>
SubjectRe: [PATCH] move omap_udc's probe function to .devinit.text
DateMon, 13 Jul 2009 14:31:54 -0700
On Monday 13 July 2009, Uwe Kleine-König wrote:
> > If it weren't a regression I wouldn't have objected.
>
> IMHO my patches primarily fix possible oopses.  I see your point that
> platform_driver_probe has some advantages,

The point is that your specific change caused a type
of regresssion ... I said nothing about "advantages",
just that your approach creates footprint regressions.


> but I consider it too
> time-consuming to check for each of the initially 60+ patches when the
> respecting devices are registered.

As a rule, preventing regressions is part of the task
description for any patch series.

Now, accidents do happen. But you had *ALREADY* gotten
NAKs for many of these patches, specifically on the
basis that they were causing these regressions. You
saved zero time by re-submitting known-broken patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-07-13 23:35    [from the cache]
©2003-2010