lkml.org 
[lkml]   [2009]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] fbdev: add fillrect and copyarea ioctls
Greg KH <gregkh@suse.de> wrote:
> On Mon, Jul 13, 2009 at 07:47:09PM +0430, Ali Gholami Rudi wrote:
> > Is there any reason for not adding these ioctls to fbdev? I searched
> > the net and couldn't any. Anyway, these patches simply implement those
> > ioctls.
>
> Have you also added the needed 32 vs. 64 bit handlers for these ioctls?

I guess Arnd's patch will do.

By the way, it should check for overflows, too? I mean should I change
this:

> + if (copy->dx + copy->width > info->var.xres ||
> + copy->sx + copy->width > info->var.xres ||
> + copy->dy + copy->height > info->var.yres ||
> + copy->sy + copy->height > info->var.yres) {

#define ISSUMLESSTHAN(a, b, s) (((a) <= (s)) && ((b) <= (s)) && \
((a) + (b) <= (s)))

if (!ISSUMLESSTHAN(copy->dx, copy->width, info->var.xres) || ...
Ali


\
 
 \ /
  Last update: 2009-07-13 22:09    [from the cache]
©2003-2011 Jasper Spaans