[lkml]   [2009]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/3] fsnotify: fix inotify tail drop check with path entries
    fsnotify drops new events when they are the same as the tail event on the
    queue to be sent to userspace. The problem is that if the event comes with
    a path we forget to break out of the switch statement and fall into the
    code path which matches on events that do not have any type of file backed
    information (things like IN_UNMOUNT and IN_Q_OVERFLOW). The problem is
    that this code thinks all such events should be dropped. Fix is to add a

    Signed-off-by: Eric Paris <>

    fs/notify/notification.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/fs/notify/notification.c b/fs/notify/notification.c
    index d1fbbea..99d840b 100644
    --- a/fs/notify/notification.c
    +++ b/fs/notify/notification.c
    @@ -150,6 +150,7 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new
    if ((old->path.mnt == new->path.mnt) &&
    (old->path.dentry == new->path.dentry))
    return true;
    + break;
    return true;

     \ /
      Last update: 2009-07-13 15:47    [W:0.025 / U:8.920 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site