lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc][patch 3/4] fs: new truncate sequence
On 07/12/2009 05:47 PM, Christoph Hellwig wrote:
> On Sun, Jul 12, 2009 at 11:55:51AM +0300, Boaz Harrosh wrote:
>> I wish you would split it.
>>
>> one - helper to be called by converted file systems
>> (Which just ignores the ATTR_SIZE)
>> second - to be set into .setattr which does the simple_setsize + above.
>>
>> More clear for FS users like me (and that ugly unmask of ATTR_SIZE)
>>
>> or it's just me?
>
> Yeah, that seems be a lot cleaner. But let's wait until we got
> rid of ->truncate for all filesystems to have the bigger picture.
>

I want to convert exofs. do you want that I call inode_setattr clearing
ATTR_SIZE bit, and at second stage remove the clearing and rename inode_setattr
to something else?

When it's time to convert exofs, tel me I'll do it. I have dependent work
on top of that, and I want to cleanup the delete_inode as well as some other
leftovers.

(BTW For none-buffer-heads systems like exofs the new way makes lots of sense)

Thanks
Boaz


\
 
 \ /
  Last update: 2009-07-12 17:03    [W:0.175 / U:2.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site