Messages in this thread | | | Date | Sun, 12 Jul 2009 10:47:18 -0400 | From | Christoph Hellwig <> | Subject | Re: [rfc][patch 3/4] fs: new truncate sequence |
| |
On Sun, Jul 12, 2009 at 11:55:51AM +0300, Boaz Harrosh wrote: > I wish you would split it. > > one - helper to be called by converted file systems > (Which just ignores the ATTR_SIZE) > second - to be set into .setattr which does the simple_setsize + above. > > More clear for FS users like me (and that ugly unmask of ATTR_SIZE) > > or it's just me?
Yeah, that seems be a lot cleaner. But let's wait until we got rid of ->truncate for all filesystems to have the bigger picture.
> > Thanks > Boaz ---end quoted text---
| |