lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] x86,APIC: Fix false positive section mismatch in numaq_32.c
From
 Impact: Fix false positive warning.

The variable apic_numaq placed in noninit section references the
function wakeup_secondary_cpu_via_nmi(), which is in __cpuinit
section. Thus causes a section mismatch warning. To avoid such
mismatch we mark apic_numaq as __refdata.

We were warned by following warning:

WARNING: arch/x86/kernel/built-in.o(.data+0x932c): Section mismatch in
reference from the variable apic_numaq to the function
.cpuinit.text:wakeup_secondary_cpu_via_nmi()
The variable apic_numaq references
the function __cpuinit wakeup_secondary_cpu_via_nmi()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

---
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
--- linus/arch/x86/kernel/apic/numaq_32.c 2009-07-12 11:27:30.000000000 +0600
+++ rakib/arch/x86/kernel/apic/numaq_32.c 2009-07-12 11:28:21.000000000 +0600
@@ -493,7 +493,8 @@ static void numaq_setup_portio_remap(voi
(u_long) xquad_portio, (u_long) num_quads*XQUAD_PORTIO_QUAD);
}

-struct apic apic_numaq = {
+/* Use __refdata to keep false positive warning calm. */
+struct apic __refdata apic_numaq = {

.name = "NUMAQ",
.probe = probe_numaq,

\
 
 \ /
  Last update: 2009-07-12 13:09    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site