lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/9] devres: WARN() and return, don't crash on device_del() of uninitialized device
    Date
    From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    I just debugged an obscure crash caused by a device_del() of a all NULL'd
    out struct device (in usb-serial) and found that a patch like this one would
    have saved me time (in addition to improved chances of a bug report from
    users hitting similar driver bugs).

    [akpm@linux-foundation.org: cleanup]
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Kay Sievers <kay.sievers@vrfy.org>
    Cc: Tejun Heo <tj@kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/base/devres.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/drivers/base/devres.c b/drivers/base/devres.c
    index e8beb8e..05dd307 100644
    --- a/drivers/base/devres.c
    +++ b/drivers/base/devres.c
    @@ -428,6 +428,9 @@ int devres_release_all(struct device *dev)
    {
    unsigned long flags;

    + /* Looks like an uninitialized device structure */
    + if (WARN_ON(dev->devres_head.next == NULL))
    + return -ENODEV;
    spin_lock_irqsave(&dev->devres_lock, flags);
    return release_nodes(dev, dev->devres_head.next, &dev->devres_head,
    flags);
    --
    1.6.3.2


    \
     
     \ /
      Last update: 2009-07-13 00:49    [W:0.021 / U:60.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site