lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] move omap_udc's probe function to .devinit.text
Date
On Sunday 12 July 2009, Russell King wrote:
>  David's approach is an enhancement whereas your patches
> are a bug fix.

Not an enhancement. Uwe's current approach causes regressions
in terms of kernel runtime footprint. That is, pages will newly
be made to sit around doing *nothing* forever, when they could
have been used to get Real Work done. And, pre-patches, they
would have been getting Real Work done.

If it weren't a regression I wouldn't have objected.

A few years back, I measured the impact of having probe() and
friends in a section -- init{,data} vs devinit{,data} -- that gets
removed. Most drivers were in the 1K-2K range. $SUBJECT was
larger than most, but there were some with even more discardable
init logic.
All that adds up. There's no point to commiting patches that
do things wrong *and* waste space, then need to fix things up
again later when it's easy to do it right in the first place.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-07-13 00:25    [from the cache]
©2003-2011 Jasper Spaans