lkml.org 
[lkml]   [2009]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC -tip] x86,apic - set cpu_has_apic for discrete apic
    [Maciej W. Rozycki - Sun, Jul 12, 2009 at 07:31:44AM +0100]
    | On Sun, 12 Jul 2009, Cyrill Gorcunov wrote:
    |
    | > Well, I've been using code reading. No real hardware test.
    | > I just don't have such a hardware.
    |
    | Then simulate it! Proofreading is not enough -- the APIC code is too
    | twisted. Be imaginative -- for example you can clear the APIC bit at the
    | time CPUID flags are saved for later use with cpu_has_apic() and see if
    | the code behaves as expected. Sprinkle printk()s here and there to see if
    | variables are set correctly, whether the right code paths are taken, etc.
    | Tedious? Well, who said kernel debugging was going to be a piece of cake?
    |
    | Most of the APIC support code I have written has been run-time tested
    | like this -- one change at a time. Do you think I have an infinite number
    | of SMP configurations too? All the clean-ups I worked on last year were
    | tested with one laptop. I didn't even have a serial port for console
    | dumps back then.
    |
    | NAK from me until you've tested it, sorry.

    Started to... hope to publish results today!
    Thanks Maciej!

    |
    | Maciej
    |
    -- Cyrill


    \
     
     \ /
      Last update: 2009-07-12 08:37    [W:0.023 / U:0.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site