Messages in this thread |  | | | Subject | Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test | | From | Jaswinder Singh Rajput <> | | Date | Sat, 11 Jul 2009 15:47:24 +0530 |
| |
On Sat, 2009-07-11 at 10:17 +0200, Jiri Slaby wrote: > On 07/11/2009 09:51 AM, Julia Lawall wrote: > > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c > > --- a/drivers/staging/otus/wwrap.c > > +++ b/drivers/staging/otus/wwrap.c > > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work) > > { > > struct usbdrv_private *macp = > > container_of(work, struct usbdrv_private, kevent); > > - zdev_t *dev = macp->device; > > + zdev_t *dev; > > > > if (macp == NULL) > > { > > return; > > } > > The test is rather useless here. >
Why useless, it should be non-null before setting to dev.
But issue is why function name like kevent() is global and who is using it.
> > + dev = macp->device; > >
Thanks, -- JSR
|  |