| From | Uwe Kleine-König <> | Subject | [PATCH] move at91_ether's probe function to .devinit.text | Date | Sat, 11 Jul 2009 22:52:32 +0200 |
| |
A pointer to at91ether_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: David S. Miller <davem@davemloft.net> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Jeff Garzik <jgarzik@redhat.com> Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt> Cc: Marc Pignat <marc.pignat@hevs.ch> Cc: Andrew Victor <linux@maxim.org.za> Cc: Roel Kluin <12o3l@tiscali.nl> Cc: Andrew Morton <akpm@linux-foundation.org> --- drivers/net/arm/at91_ether.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c index 2e7419a..0c8860e 100644 --- a/drivers/net/arm/at91_ether.c +++ b/drivers/net/arm/at91_ether.c @@ -1119,7 +1119,7 @@ static int __init at91ether_setup(unsigned long phy_type, unsigned short phy_add /* * Detect MAC and PHY and perform initialization */ -static int __init at91ether_probe(struct platform_device *pdev) +static int __devinit at91ether_probe(struct platform_device *pdev) { unsigned int phyid1, phyid2; int detected = -1; -- 1.6.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|