[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] move hgafb's probe function to .devinit.text
    A pointer to hgafb_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <>
    Cc: Krzysztof Helt <>
    Cc: Andrew Morton <>
    Cc: Anton Vorontsov <>
    Cc: Antonino Daplas <>
    drivers/video/hgafb.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c
    index 0129c04..db9b785 100644
    --- a/drivers/video/hgafb.c
    +++ b/drivers/video/hgafb.c
    @@ -551,7 +551,7 @@ static struct fb_ops hgafb_ops = {
    * Initialization

    -static int __init hgafb_probe(struct platform_device *pdev)
    +static int __devinit hgafb_probe(struct platform_device *pdev)
    struct fb_info *info;

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-07-11 23:33    [W:0.021 / U:78.100 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site