lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] move omap_udc's probe function to .devinit.text
    Date
    A pointer to omap_udc_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Philipp Zabel <philipp.zabel@gmail.com>
    Cc: David Brownell <dbrownell@users.sourceforge.net>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Russell King <rmk@arm.linux.org.uk>
    Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>
    ---
    drivers/usb/gadget/omap_udc.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
    index a2db0e1..351cb24 100644
    --- a/drivers/usb/gadget/omap_udc.c
    +++ b/drivers/usb/gadget/omap_udc.c
    @@ -2800,7 +2800,7 @@ omap_udc_setup(struct platform_device *odev, struct otg_transceiver *xceiv)
    return 0;
    }

    -static int __init omap_udc_probe(struct platform_device *pdev)
    +static int __devinit omap_udc_probe(struct platform_device *pdev)
    {
    int status = -ENODEV;
    int hmc;
    --
    1.6.3.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-11 23:33    [W:0.024 / U:0.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site