| From | Uwe Kleine-König <> | Subject | [PATCH] move sgivwfb's probe function to .devinit.text | Date | Sat, 11 Jul 2009 22:53:00 +0200 |
| |
A pointer to sgivwfb_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Antonino Daplas <adaplas@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Adrian Bunk <bunk@stusta.de> Cc: Christoph Hellwig <hch@lst.de> --- drivers/video/sgivwfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/sgivwfb.c b/drivers/video/sgivwfb.c index bba5371..aff893e 100644 --- a/drivers/video/sgivwfb.c +++ b/drivers/video/sgivwfb.c @@ -745,7 +745,7 @@ int __init sgivwfb_setup(char *options) /* * Initialisation */ -static int __init sgivwfb_probe(struct platform_device *dev) +static int __devinit sgivwfb_probe(struct platform_device *dev) { struct sgivw_par *par; struct fb_info *info; -- 1.6.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|