lkml.org 
[lkml]   [2009]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] move s3c241xfb's probe function to .devinit.text
    Date
    Pointers to s3c2410fb_probe and s3c2412fb_probe are passed to the core
    via platform_driver_register and so the functions must not disappear
    when the .init sections are discarded. Otherwise (if also having
    HOTPLUG=y) unbinding and binding a device to one of the drivers via
    sysfs will result in an oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: Ben Dooks <ben-linux@fluff.org>
    Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
    Cc: Krzysztof Helt <krzysztof.h1@wp.pl>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Antonino Daplas <adaplas@pol.net>
    Cc: Vincent Sanders <vince@simtec.co.uk>
    ---
    drivers/video/s3c2410fb.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c
    index 7da0027..b8269bd 100644
    --- a/drivers/video/s3c2410fb.c
    +++ b/drivers/video/s3c2410fb.c
    @@ -1002,12 +1002,12 @@ dealloc_fb:
    return ret;
    }

    -static int __init s3c2410fb_probe(struct platform_device *pdev)
    +static int __devinit s3c2410fb_probe(struct platform_device *pdev)
    {
    return s3c24xxfb_probe(pdev, DRV_S3C2410);
    }

    -static int __init s3c2412fb_probe(struct platform_device *pdev)
    +static int __devinit s3c2412fb_probe(struct platform_device *pdev)
    {
    return s3c24xxfb_probe(pdev, DRV_S3C2412);
    }
    --
    1.6.3.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-11 23:05    [W:0.024 / U:119.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site