lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] driver core:firmware_class:fix memory leak of page pointers array
    于 Fri, 10 Jul 2009 10:36:49 -0700
    Greg KH <greg@kroah.com> 写道:

    > On Thu, Jul 09, 2009 at 08:20:48AM +0800, Ming Lei wrote:
    > > 2009/7/9 <tom.leiming@gmail.com>:
    > > > From: Ming Lei <tom.leiming@gmail.com>
    > > >
    > > > The page pointers array is allocated in fw_realloc_buffer()
    > > > called by firmware_data_write(), and should be freed in release
    > > > function of firmware device.
    > > >
    > > > Signed-off-by:Ming Lei <tom.leiming@gmail.com>
    > > > Reported-by:Catalin Marinas <catalin.marinas@arm.com>
    > > > Acked-by: David Woodhouse <David.Woodhouse@intel.com>
    > >
    > > ---
    > > This patch is against Catalin Marinas's patch:
    > > [PATCH] Free struct device in fw_dev_release()
    >
    > Hm, I never got a final version of that patch, care to send it to me?

    It is the latest version and now is against linus mainline.
    Thanks.

    From 50603673f5c68eb843584e65cc9930919910f98a Mon Sep 17 00:00:00 2001
    From: Ming Lei <tom.leiming@gmail.com>
    Date: Thu, 9 Jul 2009 07:56:52 +0800
    Subject: [PATCH] driver core:firmware_class:fix memory leak of page pointers array

    The page pointers array is allocated in fw_realloc_buffer() called by
    firmware_data_write(), and should be freed in release function of firmware
    device.

    Signed-off-by:Ming Lei <tom.leiming@gmail.com>
    Reported-by:Catalin Marinas <catalin.marinas@arm.com>
    Acked-by: David Woodhouse <David.Woodhouse@intel.com>
    ---
    drivers/base/firmware_class.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
    index fc46653..2643366 100644
    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -180,7 +180,6 @@ static ssize_t firmware_loading_store(struct device *dev,
    goto err;
    }
    /* Pages will be freed by vfree() */
    - fw_priv->pages = NULL;
    fw_priv->page_array_size = 0;
    fw_priv->nr_pages = 0;
    complete(&fw_priv->completion);
    --
    1.6.0.GIT




    --
    Lei Ming
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-11 05:13    [W:0.024 / U:30.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site